Skip to content

8360664: Null pointer dereference in src/hotspot/share/prims/jvmtiTagMap.cpp in IterateOverHeapObjectClosure::do_object() #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8360664: Null pointer dereference in src/hotspot/share/prims/jvmtiTagMap.cpp in IterateOverHeapObjectClosure::do_object() #1982

wants to merge 1 commit into from

Conversation

savoptik
Copy link

@savoptik savoptik commented Jul 16, 2025 •
edited by openjdk bot
Loading

Hi all,

This pull request contains a backport of commit [e9a43416](https://github.com/openjdk/jdk/commit/e9a434165a6ec07cde0429c7f9823bbc5dab7857) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Artem Semenov on 7 Jul 2025 and was reviewed by Serguei Spitsyn, Alex Menkov and Chris Plummer.

This patch adds an assert that demonstrates that NULL cannot be passed to this function. This change will simplify code analysis during bug hunting and investigation.

Thanks!

Progress

  • Change must not contain extraneous whitespace
  • JDK-8360664 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8360664: Null pointer dereference in src/hotspot/share/prims/jvmtiTagMap.cpp in IterateOverHeapObjectClosure::do_object() (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1982/head:pull/1982
$ git checkout pull/1982

Update a local copy of the PR:
$ git checkout pull/1982
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1982

View PR using the GUI difftool:
$ git pr show -t 1982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1982.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2025

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e9a434165a6ec07cde0429c7f9823bbc5dab7857 8360664: Null pointer dereference in src/hotspot/share/prims/jvmtiTagMap.cpp in IterateOverHeapObjectClosure::do_object() Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Jul 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2025

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jul 17, 2025 •
edited
Loading

Hi @savoptik
please backport to 25 first.
please give an elaborate fix-request message, see also
https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

I remove the label, feel free to label again once it is in 25/25u

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

⚠️ @savoptik This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Jul 17, 2025
@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 24, 2025
@savoptik
Copy link
Author

savoptik commented Aug 4, 2025 •
edited
Loading

Hi @savoptik please backport to 25 first. please give an elaborate fix-request message, see also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

I remove the label, feel free to label again once it is in 25/25u

I apologize. I’ve already sent it in 25 and added an extended explanation here and in JBS.

@GoeLin
Copy link
Member

GoeLin commented Aug 4, 2025

I don't see why we would want to have this in 21.
It removes a null check in the product build, creating risk of crash.
If we push this now, it goes live in the October update before it's released in 25 in January.
Let's at least defer this.

@savoptik
Copy link
Author

savoptik commented Aug 5, 2025

I don't see why we would want to have this in 21. It removes a null check in the product build, creating risk of crash. If we push this now, it goes live in the October update before it's released in 25 in January. Let's at least defer this.

In the original pull request, the developers insist that null can never occur here… It started with the possibility of dereferencing further in the code… But the developers convinced me that an assertion here is enough.
Otherwise, I don’t insist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savoptik @GoeLin